Storage integration tests #211

mziccard · 2015-10-05T15:01:36Z

This PR adds integration tests for GCS (as discussed in #14).
Integration tests can be run with mvn integration-test or as part of mvn-verify.
Tests rely on two ENV variables:

GCLOUD_TESTS_PROJECT_ID: test project name
GCLOUD_TESTS_KEY: path to credentials json file

If these variables are not set, integration tests are skipped.
Integration tests are not yet triggered by travis, we first need to:

Add the encrypted credentials to the travis branch (merge Update tar to include json file #215)
Modify .travis.yml to run integration tests (commit a1e3cc4)

gcloud-java-storage/src/test/java/com/google/gcloud/storage/RemoteGcsHelper.java

+        log.log(Level.INFO, "Environment variables {0} and {1} not set", new String[] {
+            PROJECT_ID_ENV_VAR, PRIVATE_KEY_ENV_VAR});
+      }
+      return null;


- Add option to read keyfile with getResourceAsStream - Use -1 instead of 42 for (meta)generation - Add delay-timeout to listing - Make generateBucketName public and static in RemoteGcsHelper - Add static deleteBucketRecursively to RemoteGcsHelper - RemoteGcdHelper.create throws exception if env variables not set - Add javadoc to RemoteGcdHelper

mziccard · 2015-10-06T20:34:50Z

I applied the changes we discussed. Tests are still skipped if env variables are not set (so that this PR does not fail). As soon as we solve the API key issue I will fix this and add code to connect integration tests and Travis properly.
In the meantime please let me know if you have other comments.

gcloud-java-storage/src/test/java/com/google/gcloud/storage/ITStorageTest.java

+  public static void afterClass()
+      throws ExecutionException, TimeoutException, InterruptedException {
+    if (storage != null) {
+      if (!RemoteGcsHelper.deleteBucketRecursively(storage, bucket, 5, TimeUnit.SECONDS)) {


aozarov · 2015-10-07T03:44:47Z

Looks great. Few minor comments but find to merge as is.

I now wonder if deleteBucketRecursively (which I suggested, so my fault) is a good name or should
we use forceDelete(bucket) or something along this line.

- deleteBucketRecursively renamed to forceDelete - Add explicit shutdown of executor to forceDelete - Make itegration test fail if env variables are not set - Log warning if forceDelete times out

- Add utilities/verify.sh script that avoid running IT tests on PRs - Move key decryption to utilities/verify.sh (we need API key) - Call utilities/verity.sh from .travis.yml

mziccard · 2015-10-07T11:25:37Z

I updated according to the last comments.
@ajkannan could you please review commit a1e3cc4 and double check whether I used the same JSON key name you used for creating the encrypted archive? Also please let me know if you see anything that might break the build of master (PRs seem to work as this succeeded).

ajkannan · 2015-10-07T16:09:32Z

That's the same key name I created, and I don't see anything that may break the build, so that commit LGTM.

Storage integration tests

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/afc024f5-fe80-4f85-85a6-2ebee6534e1c/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@4530cc6

…cies to v0.20.1 (#211) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `0.20.0` -> `0.20.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/0.20.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/0.20.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/0.20.1/compatibility-slim/0.20.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/0.20.1/confidence-slim/0.20.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v0.20.1`](https://togithub.com/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#0201-httpswwwgithubcomgoogleapisjava-shared-dependenciescompare0200v0201-2021-03-09) [Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v0.20.0...v0.20.1) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).

🤖 I have created a release \*beep\* \*boop\* --- ## [0.3.0](https://www.github.com/googleapis/java-workflows/compare/v0.2.1...v0.3.0) (2021-03-11) ### Features * **generator:** update protoc to v3.15.3 ([#203](https://www.github.com/googleapis/java-workflows/issues/203)) ([820f34f](https://www.github.com/googleapis/java-workflows/commit/820f34fd8bf71b763216359083497929fa71dc53)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.20.1 ([#211](https://www.github.com/googleapis/java-workflows/issues/211)) ([786dfc5](https://www.github.com/googleapis/java-workflows/commit/786dfc546c75c3742a1573ee8b011e1d7ed1353c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-vpcaccess@v2.2.1...v2.3.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([efb484a](googleapis/java-vpcaccess@efb484a)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#206](googleapis/java-vpcaccess#206)) ([efb484a](googleapis/java-vpcaccess@efb484a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

🤖 I have created a release *beep* *boop* --- ## [0.5.1](googleapis/java-life-sciences@v0.5.0...v0.5.1) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-life-sciences/issues/1485)) ([#210](googleapis/java-life-sciences#210)) ([59db6ba](googleapis/java-life-sciences@59db6ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.0 (#211) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-debugger-client).

…-info-reports-plugin to v3.4.0 (#211) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-eventarc).

- [ ] Regenerate this pull request now. chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: https://github.com/googleapis/googleapis-gen/commit/6a4d9d9bb3afb20b0f5fa4f5d9f6740b1d0eb19a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9

…-plugin to v3.4.1 (#211) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-javadoc-plugin)) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-private-catalog).

…onnect to v2.3.3 (#211) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-apigee-connect](https://togithub.com/googleapis/java-apigee-connect) | `2.3.2` -> `2.3.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.3.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.3.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.3.3/compatibility-slim/2.3.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.3.3/confidence-slim/2.3.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-apigee-connect</summary> ### [`v2.3.3`](https://togithub.com/googleapis/java-apigee-connect/blob/HEAD/CHANGELOG.md#233-httpsgithubcomgoogleapisjava-apigee-connectcomparev232v233-2022-09-08) [Compare Source](https://togithub.com/googleapis/java-apigee-connect/compare/v2.3.2...v2.3.3) ##### Dependencies - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#208](https://togithub.com/googleapis/java-apigee-connect/issues/208)) ([57e46ec](https://togithub.com/googleapis/java-apigee-connect/commit/57e46ec44a786a42e5223c434340af52371a582b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-apigee-connect).

🤖 I have created a release *beep* *boop* --- ## [0.7.3](googleapis/java-dataflow@v0.7.2...v0.7.3) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#211](googleapis/java-dataflow#211)) ([65ac665](googleapis/java-dataflow@65ac665)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…ator_java versions (#211) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

…1575) (#211) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

…control to v1.3.2 (#211) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-service-control](https://togithub.com/googleapis/java-service-control) | `1.3.1` -> `1.3.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-control/1.3.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-control/1.3.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-control/1.3.2/compatibility-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-service-control/1.3.2/confidence-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-service-control).

mziccard added 2 commits October 5, 2015 16:32

Add integration test config to pom.xml

2aa9e32

Add storage integration tests

f02bd97

mziccard added api: storage Issues related to the Cloud Storage API. testing labels Oct 5, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2015

aozarov reviewed Oct 5, 2015
View reviewed changes

mziccard mentioned this pull request Oct 6, 2015

Add encrypted json credentials file #214

Closed

mziccard force-pushed the storage-integration-tests branch from 5b9eac8 to bfd4fc4 Compare October 6, 2015 20:30

aozarov reviewed Oct 7, 2015
View reviewed changes

Updated exception handling in ITStorageTest, minor refactoring

3f9f621

- deleteBucketRecursively renamed to forceDelete - Add explicit shutdown of executor to forceDelete - Make itegration test fail if env variables are not set - Log warning if forceDelete times out

mziccard force-pushed the storage-integration-tests branch from c7377d3 to 37ef974 Compare October 7, 2015 11:13

Update travis config to run integration tests

a1e3cc4

- Add utilities/verify.sh script that avoid running IT tests on PRs - Move key decryption to utilities/verify.sh (we need API key) - Call utilities/verity.sh from .travis.yml

mziccard force-pushed the storage-integration-tests branch from 37ef974 to a1e3cc4 Compare October 7, 2015 11:17

aozarov added a commit that referenced this pull request Oct 7, 2015

Merge pull request #211 from mziccard/storage-integration-tests

429ac30

Storage integration tests

aozarov merged commit 429ac30 into googleapis:master Oct 7, 2015

mziccard mentioned this pull request Oct 7, 2015

Test fail on ITStorageTest.testUpdateBlob #220

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage integration tests #211

Storage integration tests #211

mziccard commented Oct 5, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Oct 6, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Oct 7, 2015

mziccard commented Oct 7, 2015

ajkannan commented Oct 7, 2015

Storage integration tests #211

Storage integration tests #211

Conversation

mziccard commented Oct 5, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Oct 6, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Oct 7, 2015

mziccard commented Oct 7, 2015

ajkannan commented Oct 7, 2015